Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent layer naming - addresses #1462 #1500

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TNick
Copy link
Contributor

@TNick TNick commented Apr 26, 2015

The commit also changes some IPython notebooks.
Layers that were named "y" are now named "softmax" to generate same output as before.

@lamblin
Copy link
Member

lamblin commented May 6, 2015

I'm not sure about the changes to the .ipynb files, since renaming the layer from 'y' to 'softmax' will change all channels that were named 'test_y_...', for instance 'test_y_misclass'. There seem to be more of them than 'softmax_...' channels, so I would do the changes the other way around.

@lamblin lamblin self-assigned this May 6, 2015
@TNick
Copy link
Contributor Author

TNick commented May 13, 2015

Right. So - by assigning the issue to yourself - you mean that you're going to fix it or you want me to create a new pull request?

@lamblin
Copy link
Member

lamblin commented May 13, 2015

Sorry for the misunderstanding, since GitHub only lets us assign people with commit rights to the repository, we have started assigning to PRs the person who will be responsible for reviewing/merging them. It also makes it easier for me to have an overview of the PRs and tickets I should review.
If you could update this PR (I don't think you need to create a new one, if there is a conflict you can always git rebase and git push -f to the same branch), that would be great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants