Warn unused resut as macro that can be deactivated by defines #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will prepare me to integrate examples on the site with CI.
added tests cases for partition, and dispatch_apply for forward propagate of convnet
and a Border collie test image
…e to Creative Commons
1). I didn't implemented persisted connection, therefore, it is not 1.1; 2). I didn't end most of the responses properly with \n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First, thanks for the great lib :)
I'm currently working on a automatic wrapper to use it through numpy using swig. (actually work is done, I'm just publishing it ;) ). This way minimize maintaining effort and allow me to use it without cost into existing opencv/numpy code.
The small changes I'll propose in next patches are not specific to my swig effort : this will take place in different repo as if I correctly understood it's not in the philosophy of the main lib (which I totally understand). However, that's things that make it more portable and might benefit other people and that's why I propose the pull requests and I would be glad if the little things I change are reported to your main repo ;)
This first patch is about mandatory modification of the header for swig use of the lib.
From docs found, this should also be taken into account depending on gcc version (<3.4). Alternatively could be a ifndef with default value, but from what I found this way to define warn_unused_result is pretty usual.
The second one is not mandatory (as swig can ignore defs), but is about probably obsolete methods in the definition available in ccv.h