Migrate to JSON #2898
Merged
Migrate to JSON #2898
+128
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Dec 20, 2024
Comment on lines
+405
to
+406
| # Wraps JSON.protocol_encode/2 to encode maps as sorted objects | ||
| defp encode_sorting(term, encoder) when is_non_struct_map(term) do |
There was a problem hiding this comment.
This effectively reimplements the default map encoding, but it's not much code. If there is a better way to handle this, let me know!
|
Uffizzi Preview |
josevalim
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we already depend on Elixir 1.18, this replaces all usages of Jason with JSON.