Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add syncStreams option to createRoom #110

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Add syncStreams option to createRoom #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protocol
Open in desktop
Submodule protocol updated 33 files
+3 −3 .github/workflows/generate.yaml
+4 −5 go.mod
+8 −11 go.sum
+455 −0 infra/link.pb.go
+47 −0 infra/link.proto
+188 −0 infra/link_grpc.pb.go
+1,242 −726 livekit/livekit_egress.pb.go
+470 −174 livekit/livekit_egress.twirp.go
+64 −36 livekit/livekit_ingress.pb.go
+87 −84 livekit/livekit_ingress.twirp.go
+80 −41 livekit/livekit_internal.pb.go
+614 −568 livekit/livekit_models.pb.go
+178 −156 livekit/livekit_room.pb.go
+68 −66 livekit/livekit_room.twirp.go
+13 −57 livekit/types.go
+42 −1 livekit_egress.proto
+12 −5 livekit_ingress.proto
+3 −0 livekit_internal.proto
+6 −1 livekit_models.proto
+5 −1 livekit_room.proto
+2 −2 logger/config.go
+2 −2 logger/pionlogger/logadapter.go
+23 −2 logger/proto.go
+22 −0 magefile.go
+36 −0 psrpc/compilercheck.go
+4 −5 psrpc/logging.go
+37 −0 psrpc/metrics.go
+14 −14 redis/redis.go
+3 −1 rpc/egress_client.go
+96 −0 utils/bitmap.go
+99 −0 utils/bitmap_test.go
+17 −6 utils/lock_tracker.go
+3 −3 utils/timed_aggregator.go
12 changes: 12 additions & 0 deletions src/RoomServiceClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,18 @@ export interface CreateOptions {
*/
minPlayoutDelay?: number;

/**
* maximum playout delay in milliseconds
*/
maxPlayoutDelay?: number;

/**
* improves A/V sync when min_playout_delay set to a value larger than 200ms.
* It will disables transceiver re-use -- this option is not recommended
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* It will disables transceiver re-use -- this option is not recommended
* It will disable transceiver re-use -- this option is not recommended

Typo

* for rooms with frequent subscription changes
*/
syncStreams?: boolean;

/**
* override the node room is allocated to, for debugging
* does not work with Cloud
Expand Down
Loading
Loading