Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject bad request response #124

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Reject bad request response #124

merged 4 commits into from
Dec 20, 2023

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Dec 15, 2023

fixes #123
fixes #22

Copy link

changeset-bot bot commented Dec 15, 2023

🦋 Changeset detected

Latest commit: 4644c1f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-server-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

src/TwirpRPC.ts Outdated Show resolved Hide resolved
Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome fix!

@lukasIO lukasIO merged commit f4407b3 into main Dec 20, 2023
2 checks passed
@lukasIO lukasIO deleted the catch-bad-response branch December 20, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

updateParticipant throws uncatchable 500 error StartRecording throws an uncatchable axios error
3 participants