Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed imports in AgentDispatchClient.js #330

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

abhaychandavar
Copy link
Contributor

@abhaychandavar abhaychandavar commented Nov 8, 2024

Screenshot 2024-11-08 at 3 20 59 PM

File path: livekit-server-sdk/dist/AgentDispatchClient.js

Why: seems to miss .js extension in the imports leading to build issues hence making this PR leading to build issue as shown in the attachment

Fix: I've added the .js extension in imports mentioned below:

import ServiceBase from './ServiceBase';
import { TwirpRpc, livekitPackage } from './TwirpRPC';

Copy link

changeset-bot bot commented Nov 8, 2024

⚠️ No Changeset found

Latest commit: df1d29c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2024

CLA assistant check
All committers have signed the CLA.

@abhaychandavar abhaychandavar marked this pull request as draft November 8, 2024 09:53
@abhaychandavar abhaychandavar marked this pull request as ready for review November 8, 2024 09:53
@abhaychandavar abhaychandavar marked this pull request as draft November 8, 2024 09:55
@abhaychandavar abhaychandavar marked this pull request as ready for review November 8, 2024 09:57
@davidzhao
Copy link
Member

Thanks @abhaychandavar!

@davidzhao davidzhao merged commit 6ddeeb0 into livekit:main Nov 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants