Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC updates #476

Merged
merged 7 commits into from
Oct 31, 2024
Merged

RPC updates #476

merged 7 commits into from
Oct 31, 2024

Conversation

bcherry
Copy link
Contributor

@bcherry bcherry commented Oct 28, 2024

  • check the incoming request version, which we hopefully don't need to use but does allow us optionality in the future to change the protocol in a breaking way.
  • use Duration instead of millis within the Rust SDK (still uses response_timeout_ms at FFI and protocol level)
  • Use a data class for method handlers to allow the introduction of new params later without a breaking change
  • Use a data class for perform_rpc for more consistency with updates made in other SDKs

@bcherry bcherry requested a review from theomonnom October 28, 2024 19:54
@bcherry bcherry changed the title Check RPC version RPC updates Oct 28, 2024
@bcherry bcherry merged commit 91fcf57 into main Oct 31, 2024
9 of 15 checks passed
@bcherry bcherry deleted the bcherry/rpc-version branch October 31, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants