Merge pull request #48 from lizardmedia/types-compatibility-fix

Product types compatiblity fix

CHANGELOG.md

@@ -51,4 +51,7 @@
 * fix for stale downloaded files in magento root
 
 ### 1.3.8 ###
-* fix for not saving attachment
+* fix for not saving attachment
+
+### 1.3.9 ###
+* compatibility with bundle and grouped product for Magento 2.3 and 2.4 

Observer/Adminhtml/TypeConvertingPrevention.php

@@ -0,0 +1,59 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * File: TypeConvertingPrevention.php
+ *
+ * @author Bartosz Kubicki [email protected]>
+ * @copyright Copyright (C) 2021 Lizard Media (http://lizardmedia.pl)
+ */
+
+namespace LizardMedia\ProductAttachment\Observer\Adminhtml;
+
+use Magento\Framework\App\RequestInterface;
+use Magento\Framework\Event\Observer;
+use Magento\Framework\Event\ObserverInterface;
+
+/**
+ * Class TypeConvertingPrevention
+ * @package LizardMedia\ProductAttachment\Observer\Adminhtml
+ */
+class TypeConvertingPrevention implements ObserverInterface
+{
+    /**
+     * @var RequestInterface
+     */
+    private $request;
+
+    /**
+     * @param RequestInterface $request
+     */
+    public function __construct(
+        RequestInterface $request
+    ) {
+        $this->request = $request;
+    }
+
+    /**
+     * @param Observer $observer
+     * @return void
+     */
+    public function execute(Observer $observer): void
+    {
+        $product = $observer->getEvent()->getProduct();
+        $type = $this->request->getParam('type');
+
+        if (!empty($type) && in_array($type, $this->getProductType(), true)) {
+            $product->setTypeId($type);
+        }
+    }
+
+    /**
+     * @return string[]
+     */
+    private function getProductType(): array
+    {
+        return ['bundle', 'grouped'];
+    }
+}

composer.json

@@ -9,7 +9,7 @@
         "magento/module-ui": "*"
     },
     "type": "magento2-module",
-    "version": "1.3.8",
+    "version": "1.3.9",
     "license": [
         "MIT"
     ],

etc/adminhtml/di.xml

@@ -48,4 +48,4 @@
     </type>
     <!-- End of proxy section -->
 
-</config>
+</config>

etc/adminhtml/events.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0"?>
+<!--
+/**
+ * @author Bartosz Kubicki <[email protected]>
+ * @copyright Copyright (C) 2021 Lizard Media (http://lizardmedia.pl)
+ */
+-->
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
+        <event name="catalog_product_save_before">
+            <observer name="LizardMedia_ProductAttachment::typeConvertingPrevention" instance="LizardMedia\ProductAttachment\Observer\Adminhtml\TypeConvertingPrevention"/>
+        </event>
+</config>

etc/di.xml

@@ -100,4 +100,4 @@
     </type>
     <!-- End of metadataPool section -->
 
-</config>
+</config>

etc/module.xml

@@ -7,7 +7,7 @@
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="LizardMedia_ProductAttachment" setup_version="1.3.8">
+    <module name="LizardMedia_ProductAttachment" setup_version="1.3.9">
         <sequence>
             <module name="Magento_Downloadable"/>
             <module name="Magento_Catalog"/>