[New]: parse: add throwOnLimitExceeded option
#517
Merged
+162
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
ljharb
requested changes
Nov 12, 2024
ljharb
reviewed
Nov 12, 2024
ljharb
changed the title
parse: add throwOnParameterLimitExceeded optionparse: add throwOnLimitExceeded option
ljharb
reviewed
Nov 12, 2024
IamLizu
commented
Nov 17, 2024
ljharb
approved these changes
Nov 17, 2024
ljharb
force-pushed
the
feat/throw-when-parameter-limit-reached
branch
5 times, most recently
from
f38634b to
ef0b96f
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in expressjs/express#5878 about adding an option to enable throwing error when parameter limit exceeded, I have,
throwOnLimitExceededwhich isfalseby default.Additionally, as #515 suggests about throwing an error in case of any limit is exceeded, it has been implemented as well.
References
parse: add new option to throw whenparameterLimitis reached #515