fix: sanitize priced balances (#756)

llamafolio · Aug 8, 2023 · d97672c · d97672c
1 parent 76dfeb2
commit d97672c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/src/handlers/updateBalances.ts b/src/handlers/updateBalances.ts
@@ -5,7 +5,7 @@ import type { BalancesGroup } from '@db/balances-groups'
 import { getAllContractsInteractions, groupContracts } from '@db/contracts'
 import type { Balance, BalancesConfig, BalancesContext, PricedBalance } from '@lib/adapter'
 import { groupBy, groupBy2 } from '@lib/array'
-import { fmtBalanceBreakdown, sanitizeBalances } from '@lib/balance'
+import { fmtBalanceBreakdown, sanitizeBalances, sanitizePricedBalances } from '@lib/balance'
 import { type Chain, chains } from '@lib/chains'
 import { sum } from '@lib/math'
 import { getPricedBalances } from '@lib/price'
@@ -128,16 +128,18 @@ export async function updateBalances(client: PoolClient, address: `0x${string}`)
 
   const pricedBalances = await getPricedBalances(sanitizedBalances)
 
+  const sanitizedPricedBalances = sanitizePricedBalances(pricedBalances)
+
   const hrend = process.hrtime(hrstart)
 
   console.log(
-    `getPricedBalances ${sanitizedBalances.length} balances, found ${pricedBalances.length} balances in %ds %dms`,
+    `getPricedBalances ${sanitizedBalances.length} balances, found ${balances.length} balances, ${sanitizedPricedBalances.length} sanitized in %ds %dms`,
     hrend[0],
     hrend[1] / 1000000,
   )
 
   // Group balances back by adapter/chain
-  const pricedBalancesByAdapterIdChain = groupBy2(pricedBalances, 'adapterId', 'chain')
+  const pricedBalancesByAdapterIdChain = groupBy2(sanitizedPricedBalances, 'adapterId', 'chain')
 
   const now = new Date()
 

diff --git a/src/lib/balance.ts b/src/lib/balance.ts
@@ -14,6 +14,13 @@ import { providers } from '@lib/providers'
 import type { Token } from '@lib/token'
 import { isNotNullish } from '@lib/type'
 
+/**
+ * Min and Max range for a balance unit (in USD).
+ * Balances that don't fit in this range are discarded in the update balance process
+ */
+export const MIN_BALANCE_USD = 0.00001
+export const MAX_BALANCE_USD = 10_000_000_000
+
 export async function getBalances(ctx: BalancesContext, contracts: BaseContract[]) {
   const coins: Token[] = []
   const tokensByChain: { [key: string]: Token[] } = {}
@@ -140,6 +147,13 @@ export function sanitizeBalances<T extends Balance>(balances: T[]) {
   return sanitizedBalances
 }
 
+export function sanitizePricedBalances<T extends PricedBalance>(balances: T[]) {
+  return balances.filter(
+    (balance) =>
+      balance.balanceUSD != null && balance.balanceUSD >= MIN_BALANCE_USD && balance.balanceUSD <= MAX_BALANCE_USD,
+  )
+}
+
 export async function resolveBalances<C extends GetContractsHandler>(
   ctx: BalancesContext,
   contracts: ExcludeRawContract<Partial<Awaited<ReturnType<C>>['contracts']>>,