Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to use python3 #4

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

keith
Copy link
Contributor

@keith keith commented Mar 19, 2022

This converts this plugin to require python3 and not support python2 since it has long been end of life and is finally gone from macOS as well.

Fixes #3

This was referenced Mar 19, 2022
@keith
Copy link
Contributor Author

keith commented Mar 19, 2022

This doesn't have any of the other improvements from #1, but I figured we could figure that out later and his is enough to make things work

* Mac OS X (tested on Mountain Lion)
* Vim command-line (7.3 from Xcode)
* macOS (tested on Monterey)
* Vim command-line (8.2 from homebrew)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really true because of #2

I was able to get this working with neovim pointing at system python on macOS, but that isn't really up to this plugin

Copy link
Member

@JDevlieghere JDevlieghere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@JDevlieghere JDevlieghere merged commit fef40a9 into lldb-tools:master Mar 19, 2022
@keith keith deleted the ks/convert-to-use-python3 branch March 19, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3 support
2 participants