Use nan to support node 0.12 #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dohse
force-pushed
the
use-nan
branch
2 times, most recently
from
3ce31f9
to
76957cf
Compare
dohse
force-pushed
the
use-nan
branch
3 times, most recently
from
284128e
to
368b3d7
Compare
|
+1 |
|
@dohse Can you add |
| @@ -4,7 +4,8 @@ | |||
| "homepage": "https://github.com/lloyd/node-toobusy", | |||
| "version": "0.2.4", | |||
| "dependencies": { | |||
| "bindings": "1.1.0" | |||
| "bindings": "1.1.0", | |||
| "nan": "1.6.2" | |||
There was a problem hiding this comment.
Can you update this to nan v1.8.4? That would allow toobusy to install on io.js.
dohse
force-pushed
the
use-nan
branch
3 times, most recently
from
58b7a5f
to
c56e8b9
Compare
|
@leedm777 I updated this PR accordingly |
|
👍 |
|
@lloyd Any objection to merging this PR? It's helpful for anyone trying to move forward with newer versions of Node.js. |
dohse
force-pushed
the
use-nan
branch
2 times, most recently
from
7692532
to
51c4400
Compare
dohse
force-pushed
the
use-nan
branch
10 times, most recently
from
6aec270
to
349b437
Compare
dohse
force-pushed
the
use-nan
branch
3 times, most recently
from
1faaf93
to
5761dec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.