Skip to content

Commit

Permalink
[memprof] Make ContextNode smaller (#116271)
Browse files Browse the repository at this point in the history
With this patch, sizeof(ContextNode) goes down from 144 to 128.

Note that SmallVector<T, 0> uses uint32_t for its capacity and size
fields.

I could change other instances of std::vector to SmallVector<T, 0>,
but that would require updates to many places, so I am leaving them
alone for now.
  • Loading branch information
kazutakahirata authored Nov 15, 2024
1 parent 40a647f commit 17bc738
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions llvm/lib/Transforms/IPO/MemProfContextDisambiguation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,10 @@ class CallsiteContextGraph {
// recursion.
bool Recursive = false;

// This will be formed by ORing together the AllocationType enum values
// for contexts including this node.
uint8_t AllocTypes = 0;

// The corresponding allocation or interior call. This is the primary call
// for which we have created this node.
CallInfo Call;
Expand All @@ -255,7 +259,7 @@ class CallsiteContextGraph {
// through cloning. I.e. located in the same function and have the same
// (possibly pruned) stack ids. They will be updated the same way as the
// primary call when assigning to function clones.
std::vector<CallInfo> MatchingCalls;
SmallVector<CallInfo, 0> MatchingCalls;

// For alloc nodes this is a unique id assigned when constructed, and for
// callsite stack nodes it is the original stack id when the node is
Expand All @@ -266,10 +270,6 @@ class CallsiteContextGraph {
// clones.
uint64_t OrigStackOrAllocId = 0;

// This will be formed by ORing together the AllocationType enum values
// for contexts including this node.
uint8_t AllocTypes = 0;

// Edges to all callees in the profiled call stacks.
// TODO: Should this be a map (from Callee node) for more efficient lookup?
std::vector<std::shared_ptr<ContextEdge>> CalleeEdges;
Expand Down

0 comments on commit 17bc738

Please sign in to comment.