[libc++] Address post-commit comments for __scope_guard #116291
+7
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philnik777
commented
Nov 14, 2024
| __other.__moved_from_ = true; | ||
| } | ||
| private: | ||
| __scope_guard(__scope_guard&&); |
There was a problem hiding this comment.
I'm not sure whether this approach is better than having dead code. @ldionne thoughts?
There was a problem hiding this comment.
Oh, I like this a lot better than the previous approach. There's not much harm in providing this private declaration.
There was a problem hiding this comment.
Uh... this actually has to be public. Sometimes my brain just turns off. Does that change your thoughts on this?
There was a problem hiding this comment.
It doesn't, but thanks for checking.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
ldionne
approved these changes
Nov 14, 2024
| __other.__moved_from_ = true; | ||
| } | ||
| private: | ||
| __scope_guard(__scope_guard&&); |
There was a problem hiding this comment.
Oh, I like this a lot better than the previous approach. There's not much harm in providing this private declaration.
philnik777
force-pushed
the
fix_scope_guard
branch
from
a91e0de
to
8710b85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #116204