[Runtimes] Merge 'compile_commands.json' files from runtimes build #116303
Conversation
jhuber6
requested review from
compnerd,
jdoerfert,
llvm-beanz,
MaskRay,
petrhosek and
shiltian
| @@ -0,0 +1,42 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Do we need LLVM copyright here?
There was a problem hiding this comment.
Don't think so, none of the other utility scripts I saw had one.
| data = json.load(f) | ||
| merged_data.extend(data) | ||
| except (IOError, json.JSONDecodeError): | ||
| continue |
There was a problem hiding this comment.
probably drop a warning or so here
|
✅ With the latest revision this PR passed the Python code formatter. |
Summary: When building a project in a runtime mode, the compilation database is a separate CMake invocation. So its `compile_commands.json` file will be placed elsewhere in the `runtimes/runtime-bins` directory. This is somewhat annoying for ongoing development when a runtimes build is necessary. This patch adds some CMake magic to merge the two files.
jhuber6
force-pushed
the
JSONCommands
branch
from
11aab09
to
458aee6
Compare
| ${LLVM_BINARY_DIR}/compile_commands.json | ||
| ${CMAKE_BINARY_DIR}/compile_commands.json | ||
| -o ${LLVM_BINARY_DIR}/compile_commands.json | ||
| DEPENDS ${CMAKE_BINARY_DIR}/compile_commands.json) |
There was a problem hiding this comment.
IIUC this custom command will just depend on the main compile_commands.json, which is generated after CMake configuration. However, the runtime build is the last stage of build, so I'm not sure if this dependency can push it back to the end.
There was a problem hiding this comment.
Yeah I'm not 100% positive on how this will work out. When I test it under normal circumstances (fresh build and modification of files) it works fine. however if I manually delete the main compile_commands.json it will get into a dumb state where it keeps thinking it's not there.
Summary:
When building a project in a runtime mode, the compilation database is a
separate CMake invocation. So its
compile_commands.jsonfile will beplaced elsewhere in the
runtimes/runtime-binsdirectory. This issomewhat annoying for ongoing development when a runtimes build is
necessary. This patch adds some CMake magic to merge the two files.