[flang][cuda] Support memory cleanup at a return statement #116304
+38
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generate
cuf.free
andfunc.return
twice if a return statement exists at the end of program.Dumped IR:
The routine
genExitRoutine
inBridge.cpp
is guarded byblockIsUnterminated()
to make sure thatfunc.return
is generated only at the end of a block. However, we redundantly runbridge.fctCtx().finalizeAndKeep()
beforegenExitRoutine
in this case, resulting in two pairs ofcuf.free
andfunc.return
. This PR fixesBridge.cpp
by usingblockIsUnterminated()
to guardfinalizeAndKeep
as well.