[llvm] APFloat: Add helpers to query NaN/inf semantics
#116315
+28
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
matthias-springer
force-pushed
the
users/matthias-springer/has_nan_inf
branch
from
64568e5
to
1668bd7
Compare
matthias-springer
force-pushed
the
users/matthias-springer/has_nan_inf
branch
from
1668bd7
to
da41f0f
Compare
| bool APFloatBase::semanticsHasNanOrInf(const fltSemantics &semantics) { | ||
| bool APFloatBase::semanticsHasInf(const fltSemantics &semantics) { | ||
| return semantics.nonFiniteBehavior != fltNonfiniteBehavior::NanOnly && | ||
| semantics.nonFiniteBehavior != fltNonfiniteBehavior::FiniteOnly; |
There was a problem hiding this comment.
Since the only other one left is IEEE semantics, should we check (== IEEE754) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APFloatchanges extracted from #116176 as per reviewer comments.