-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Github] Add labels on pull requests based on paths. #65308
Conversation
Obviously the provided rules are far from complete, but that seems sufficient to seed the effort and other people can all labels as they see fit. This has not been tested, not sure how testing that sort of change can be done. |
Push to your fork and open a PR towards your fork instead of main. This looks fine to me. It's a shame that we can't use the same mapping as CODEOWNERS since this means we will have to dupe the "rules" in both places. But I still think it is worth doing. |
Using https://github.com/actions/labeler, this add a workflow to automatically label PRs, in hope to reduce the work needed to triage new PRs. "new-prs-labeler.yml" has been seeded taking inspiration from the CODEOWNERS file when there was an existing corresponding label on the issue tracker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some way we can pull all the path information from the CODEOWNERS file? It doesn't seem great to have this information duplicated in two places.
Sadly no, first because the labeler does not support it, and there isn't a perfect match between the labels and the teams |
Using https://github.com/actions/labeler, this add a workflow to automatically label PRs, in hope to reduce the work needed to triage new PRs. "new-prs-labeler.yml" has been seeded taking inspiration from the CODEOWNERS file when there was an existing corresponding label on the issue tracker.
Using https://github.com/actions/labeler, this add a workflow to automatically label PRs, in hope to reduce the work needed to triage new PRs.
"new-prs-labeler.yml" has been seeded taking inspiration from the CODEOWNERS file when there was an existing corresponding label on the issue tracker.