Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document misspelling #1312

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Fix document misspelling #1312

merged 5 commits into from
Aug 23, 2023

Conversation

KyleChuang
Copy link
Contributor

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • VPR
  • Tileable routing architecture generator
  • OpenFPGA libraries
  • FPGA-Verilog
  • FPGA-Bitstream
  • FPGA-SDC
  • FPGA-SPICE
  • Flow scripts
  • Architecture library
  • Cell library
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

Copy link
Collaborator

@tangxifan tangxifan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KyleChuang Thanks for contribution. However, I see you format the CMakeList.txt. The formatting standard for CMakeList.txt has not been decided yet. I would like to do more researches before making such decision. Other changes look fine.

If you can revert the changes in CMakeLists.txt, we can merge this PR.

@KyleChuang
Copy link
Contributor Author

Hello
I revert CMakelists.txt based on your suggestion.

@tangxifan tangxifan merged commit e09c364 into lnis-uofu:master Aug 23, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants