Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for k8s native sidecars using restartable init containers #50

Merged
merged 2 commits into from
Aug 21, 2024
Merged

feat: Add support for k8s native sidecars using restartable init containers #50

merged 2 commits into from
Aug 21, 2024

Conversation

AdamSendible
Copy link
Contributor

  • Allows devpod provider to work with k8s native sidecars
    • This is done by checking the restart policy on init containers is set to Always
    • For all other init containers the default behaviour exists to wait for those to complete
  • Improved the provider build script to allow GitHub forks to build and release assets

@pascalbreuninger
Copy link
Member

pascalbreuninger commented Aug 21, 2024 •
edited
Loading

@AdamSendible great addition, thanks for the PR!

I've kicked off a new alpha release so you can test end to end: v0.1.12-alpha.2

Let me know if everything works alright so we can release a new stable version

@pascalbreuninger pascalbreuninger merged commit 278fe13 into loft-sh:main Aug 21, 2024
1 check passed
@AdamSendible AdamSendible deleted the feat/native-sidecars branch August 21, 2024 16:05
@AdamSendible
Copy link
Contributor Author

Thanks for the review @pascalbreuninger. I have tested with v0.1.12-alpha.2 and all seems to work as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalbreuninger pascalbreuninger pascalbreuninger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamSendible @pascalbreuninger