chore(vclusterctl): consolidate vcluster cli and platform config #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
johannesfrey
force-pushed
the
vclusterctl-single-config-2
branch
6 times, most recently
from
c12ce10
to
f3eb913
Compare
johannesfrey
changed the title
johannesfrey
force-pushed
the
vclusterctl-single-config-2
branch
12 times, most recently
from
1bd154e
to
117e0e4
Compare
johannesfrey
commented
May 21, 2024
| ) | ||
|
|
||
| type Config struct { | ||
| TelemetryDisabled bool `json:"telemetryDisabled,omitempty"` |
There was a problem hiding this comment.
Decided to not wrap this in e.g. CLIConfig, as this would break current ~/.vcluster/config.json configs that have telemetry settings configured.
johannesfrey
force-pushed
the
vclusterctl-single-config-2
branch
5 times, most recently
from
06f6f63
to
5066aa4
Compare
johannesfrey
force-pushed
the
vclusterctl-single-config-2
branch
2 times, most recently
from
be46e11
to
b21e860
Compare
johannesfrey
force-pushed
the
vclusterctl-single-config-2
branch
from
b21e860
to
f97e7d4
Compare
johannesfrey
force-pushed
the
vclusterctl-single-config-2
branch
5 times, most recently
from
57e15dd
to
ed6e1fa
Compare
johannesfrey
force-pushed
the
vclusterctl-single-config-2
branch
from
ed6e1fa
to
a94a3a1
Compare
|
Closed in favour of #1798 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Part of ENG-3722
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster would create multiple config files in multiple places.
What else do we need to know?
--configflagUpdated the loft deps to incorporate: https://github.com/loft-sh/loft-enterprise/commit/bd4285e840c1c3d4157265a71e72daaae6f12c51
Therefore, many changed files are actual changes in
vendor, which don't need to be reviewed.