Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.20] Merge pull request #2240 from rmweir/fix-auth-lock #2242

Merged
merged 1 commit into from
Oct 22, 2024

Commits on Oct 22, 2024

  1. Remove use of client from CLI setup

    Prior, we were using a kubeconfig client during setup of the platform
    commands. The client uses the command "vcluster platform token". This
    would cause an endless loop like the following:
    1. you run the "vcluster platform ..." command
    2. vcluster makes request to /deployments endpoint, before running
    the intended command.
    3. the k8s client uses vcluster to authenticate the request
    4. return to step 2
    The request was being made to detect the platform namespace and set
    it as the default namespace for the backup management command. Now,
    there is not a default that is set ahead of running the command but
    if a value was not passed, the CLI will then search for the platform
    namespace.
    
    (cherry picked from commit a5622f9)
    rmweir committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    20f0b24 View commit details
    Browse the repository at this point in the history