Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update stylelint rules #52

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

update stylelint rules #52

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3af5150
update stylelint rules
serrazina Oct 10, 2017
c31581f
update stylelint rules
serrazina Oct 11, 2017
a635b89
update stylelint rules
serrazina Oct 12, 2017
440cbc7
update postcss & stylint versions
serrazina Oct 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions .stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
],
"rules": {
"at-rule-empty-line-before": ["always", {
"except": ["blockless-group", "first-nested"],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing the blockless-after-same-name-blockless for the sequencial @import expressions.

"except": ["first-nested"],
"ignore": ["after-comment"]
}],
"block-closing-brace-newline-after": "always",
Expand All @@ -27,7 +27,6 @@
"declaration-bang-space-before": "always",
"declaration-block-no-duplicate-properties": true,
"declaration-block-no-shorthand-property-overrides": true,
"declaration-block-properties-order": "alphabetical",
"declaration-block-semicolon-newline-after": "always-multi-line",
"declaration-block-semicolon-space-after": "always-single-line",
"declaration-block-semicolon-space-before": "never",
Expand All @@ -37,6 +36,7 @@
"declaration-colon-space-after": "always-single-line",
"declaration-colon-space-before": "never",
"declaration-no-important": true,
"font-family-no-duplicate-names" : true,
"font-family-name-quotes": "always-where-recommended",
"font-weight-notation": "numeric",
"function-calc-no-unspaced-operator": true,
Expand All @@ -58,25 +58,20 @@
"max-nesting-depth": 3,
"media-feature-colon-space-after": "always",
"media-feature-colon-space-before": "never",
"media-feature-no-missing-punctuation": true,
"media-feature-range-operator-space-after": "always",
"media-feature-range-operator-space-before": "always",
"media-query-list-comma-newline-after": "always-multi-line",
"media-query-list-comma-space-after": "always-single-line",
"media-query-list-comma-space-before": "never",
"media-query-parentheses-space-inside": "never",
"no-descending-specificity": true,
"no-duplicate-selectors": true,
"no-eol-whitespace": true,
"no-invalid-double-slash-comments": true,
"no-missing-eof-newline": true,
"no-unknown-animations": true,
"number-leading-zero": "never",
"number-max-precision": 2,
"number-no-trailing-zeros": true,
"rule-non-nested-empty-line-before": ["always", {
"ignore": ["after-comment"]
}],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one changed to rule-empty-line-before and I think it's mandatory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I will replace that.

"property-no-unknown": true,
"scss/at-import-no-partial-leading-underscore": true,
"scss/selector-no-redundant-nesting-selector": true,
"selector-combinator-space-after": "always",
Expand All @@ -86,15 +81,13 @@
"selector-list-comma-space-after": "always-single-line",
"selector-list-comma-space-before": "never",
"selector-max-specificity": "0,4,0",
"selector-no-id": true,
"selector-no-type": true,
"selector-no-universal": true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except the no-type, I think it makes sense to keep this.

Copy link

@liciniofs liciniofs Oct 10, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

"selector-no-vendor-prefix": true,
"selector-pseudo-element-colon-notation": "double",
"selector-type-case": "lower",
"shorthand-property-no-redundant-values": true,
"string-no-newline": true,
"string-quotes": "double",
"time-no-imperceptible": true,
"unit-no-unknown" : true,
"value-list-comma-newline-after": "always-multi-line",
"value-list-comma-newline-before": "never-multi-line",
"value-list-comma-space-after": "always-single-line",
Expand Down