-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new rules in tag_windows.txt to application_execution tag #4376
base: main
Are you sure you want to change the base?
Conversation
@lprat FYI tests are failing due to an issue flagged by the linter
|
tests/data/tag_windows.py
Outdated
event.timestamp = self._TEST_TIMESTAMP | ||
event.timestamp_desc = definitions.TIME_DESCRIPTION_UNKNOWN | ||
|
||
event_data = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't do it like this. Use the corresponding event data object instead.
The intent of these test are to catch issues when the event data objects change.
Codecov ReportBase: 85.77% // Head: 85.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4376 +/- ##
==========================================
- Coverage 85.77% 85.71% -0.06%
==========================================
Files 413 413
Lines 35449 35430 -19
==========================================
- Hits 30407 30370 -37
- Misses 5042 5060 +18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sorry for all the corrections! I hope it's good for you? |
@lprat no worries, take your time. I'll try to have a look tomorrow, when time permits. |
One line description of pull request
Add new tag in data/tag_windows.txt to "application_execution".
Description:
Add new tag in data/tag_windows.txt to "application_execution":
Event "Microsoft-Windows-Security-Auditing" id 4673:
Event "Microsoft-Windows-Security-Auditing" id 4798 & 4799:
Event sysmon id 1 :
Event "Microsoft-Windows-Application-Experience" ID 500 & 505:
Extracted by plaso parser in data_type: 'windows:srum:application_usage'
Extracted by plaso parser in data_type: 'windows:registry:amcache'
Extracted by plaso parser in data_type: 'windows:timeline:user_engaged'
Registries path key:
Notes:
All contributions to Plaso undergo code
review. This makes sure
that the code has appropriate test coverage and conforms to the Plaso style
guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in
order, and then a maintainer will review your code.
Checklist: