Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(StakeVault): make unstaking actually work #41

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix(StakeVault): make unstaking actually work #41

merged 1 commit into from
Jan 19, 2024

Commits on Jan 17, 2024

  1. fix(StakeVault): make unstaking actually work 

    Unstaking didn't actually work because it was using `transferFrom()` on the
`StakeVault` with the `from` address being the vault itself.
This would result in an approval error because the vault isn't creating
any approvals to spend its own funds.

The solution is to use `transfer` instead and ensuring the return value
is checked.
    @0x-r4bbit
    0x-r4bbit committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1ec8ad3 View commit details
    Browse the repository at this point in the history