Fix the merge function of the mutate filter #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dest_field_value was derived before the added fields were iterated upon. This caused the subsequent `event.set`'s, when iterating over multiple `added_field_value`'s, to set the `dest_field` based on the _initial_ `dest_field_value`. The logic should, instead, update the `dest_field_value` on each iteration of `added_field` so that it may continue to add to the `dest_field_value` instead of always only adding the last item in the list.
|
💚 CLA has been signed |
|
I have signed the contributor agreement |
|
Awesome, thanks much! Pls don't hesitate to LMK if further work/assistance is needed to get this resolved :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dest_field_value was derived before the added fields were iterated upon. This caused the subsequent
event.set's, when iterating over multipleadded_field_value's, to set thedest_fieldbased on the initialdest_field_value.The logic should, instead, update the
dest_field_valueon each iteration ofadded_fieldso that it may continue to add to thedest_field_valueinstead of always only adding the last item in the list.Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/