-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable adding new convertion functions #48
base: main
Are you sure you want to change the base?
Conversation
…e it in class inheriting from Mutate
Hi, On the other side, i'm wondering what drove you to propose this change? for now mutations are operations written inside the same mutate class. Do you have a concrete improvement proposal that would use this change? Thanks a lot, |
Hi and thanks for your time, I signed the CLA as required. |
I don't quite understand the goal of this change. Can you explain more? It sounds like you are subclassing the mutate filter? Can you help me understand why and what you are doing? |
I want to add a specific geo conversion from one geo format to another. What my change does is it makes the valid_conversions variable a class variable so that I can change it in my subclass and add other valid conversions (such as GeoJson). |
When I said "class variable" I meant instance variable actually.. |
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
Changed valid_conversions to be an instance variable so that it can be overridden in classes inheriting from Mutate. This will allow adding new convert functions simply by inheriting from the Mutate class.