Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release logzio-metrics-collector chart v0.0.1 #520

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ralongit
Copy link
Contributor

@ralongit ralongit commented Aug 8, 2024

No description provided.

@ralongit ralongit requested a review from 8naama August 8, 2024 09:00
Copy link
Contributor

@8naama 8naama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉 Left a few small comments

charts/logzio-metrics-collector/VALUES.md Outdated Show resolved Hide resolved
charts/logzio-metrics-collector/templates/NOTES.txt Outdated Show resolved Hide resolved
charts/logzio-metrics-collector/templates/_pod.tpl Outdated Show resolved Hide resolved
charts/logzio-metrics-collector/templates/_pod.tpl Outdated Show resolved Hide resolved
charts/logzio-metrics-collector/templates/_pod.tpl Outdated Show resolved Hide resolved
Comment on lines +188 to +205
Calculate Logz.io listener address based on region
*/}}
{{- define "logzio.listenerAddress" -}}
{{- $region := .Values.secrets.logzioRegion -}}
{{- if eq $region "us" -}}
https://listener.logz.io:8053
{{- else if eq $region "au" -}}
https://listener-au.logz.io:8053
{{- else if eq $region "ca" -}}
https://listener-ca.logz.io:8053
{{- else if eq $region "eu" -}}
https://listener-eu.logz.io:8053
{{- else if eq $region "uk" -}}
https://listener-uk.logz.io:8053
{{- else -}}
https://listener.logz.io:8053 # Default to us-east-1 region if no match
{{- end -}}
{{- end }}
Copy link
Contributor

@8naama 8naama Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be shortened:

{{- define "logzio.listenerAddress" -}}
{{- $region := .Values.secrets.logzioRegion }}
{{- if or (eq $region "us") (not $region) }}
https://listener.logz.io:8053
{{- else }}
{{ printf "https://listener-%s.logz.io:8053" $region }}
{{- end }}
{{- end }}

and to verify the value it ca be done in the NOTES.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants