Skip to content

Commit

Permalink
Changes requested in PR review.
Browse files Browse the repository at this point in the history
Signed-off-by: James Munson <[email protected]>
  • Loading branch information
james-munson authored and David Ko committed Sep 11, 2023
1 parent ab05664 commit 0b22c15
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 11 deletions.
4 changes: 2 additions & 2 deletions content/docs/1.5.0/references/storage-class-parameters.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,9 @@ A list of recurring jobs that are to be run on a volume.
> More details in [Scheduling](../../volumes-and-nodes/scheduling).
#### Backend Store Driver *(field: `parameters.backendStoreDriver`)*
> Default: `""`
> Default: `"v1"`
- Use "spdk" to run the v2 SPDK-based engine.
- Use "v2" to run the v2 SPDK-based engine (experimental in 1.5.) If empty, "v1" is assumed.

> Global setting: [V2 Data Engine](../settings#v2-data-engine).
> More details in [V2 Data Engine Quick Start](../../spdk/quick-start#create-a-storageclass).
Expand Down
4 changes: 2 additions & 2 deletions content/docs/1.5.1/references/storage-class-parameters.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,9 @@ A list of recurring jobs that are to be run on a volume.
> More details in [Scheduling](../../volumes-and-nodes/scheduling).
#### Backend Store Driver *(field: `parameters.backendStoreDriver`)*
> Default: `""`
> Default: `"v1"`
- Use "spdk" to run the v2 SPDK-based engine.
- Use "v2" to run the v2 SPDK-based engine (experimental in 1.5.) If empty, "v1" is assumed.

> Global setting: [V2 Data Engine](../settings#v2-data-engine).
> More details in [V2 Data Engine Quick Start](../../spdk/quick-start#create-a-storageclass).
Expand Down
4 changes: 2 additions & 2 deletions content/docs/1.5.2/references/storage-class-parameters.md
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,9 @@ A list of recurring jobs that are to be run on a volume.
> More details in [Scheduling](../../volumes-and-nodes/scheduling).
#### Backend Store Driver *(field: `parameters.backendStoreDriver`)*
> Default: `""`
> Default: `"v1"`
- Use "spdk" to run the v2 SPDK-based engine.
- Use "v2" to run the v2 SPDK-based engine (experimental in 1.5.) If empty, "v1" is assumed.

> Global setting: [V2 Data Engine](../settings#v2-data-engine).
> More details in [V2 Data Engine Quick Start](../../spdk/quick-start#create-a-storageclass).
Expand Down
10 changes: 7 additions & 3 deletions content/docs/1.6.0/references/settings.md
Original file line number Diff line number Diff line change
Expand Up @@ -577,15 +577,18 @@ When this setting is un-checked, the Longhorn Manager will schedule replicas on
When this setting is checked, the Longhorn Manager will allow scheduling on nodes with existing healthy replicas of the same volume.

When this setting is un-checked, the Longhorn Manager will not allow scheduling on nodes with existing healthy replicas of the same volume.
When this setting is un-checked, Longhorn Manager will forbid scheduling on nodes with existing healthy replicas of the same volume.

> **Note:**
> - This setting is superseded if replicas are forbidden to share a zone by the Replica Zone Level Anti-Affinity setting.
#### Replica Zone Level Soft Anti-Affinity

> Default: `true`
When this setting is checked, the Longhorn Manager will allow scheduling new replicas of a volume to the nodes in the same zone as existing healthy replicas.

When this setting is un-checked, Longhorn Manager will not allow scheduling new replicas of a volume to the nodes in the same zone as existing healthy replicas.
When this setting is un-checked, Longhorn Manager will forbid scheduling new replicas of a volume to the nodes in the same zone as existing healthy replicas.

> **Note:**
> - Nodes that don't belong to any zone will be treated as if they belong to the same zone.
Expand All @@ -597,10 +600,11 @@ When this setting is un-checked, Longhorn Manager will not allow scheduling new
When this setting is checked, the Longhorn Manager will allow scheduling new replicas of a volume to the same disks as existing healthy replicas.

When this setting is un-checked, Longhorn Manager will not allow scheduling new replicas of a volume to the same disks as existing healthy replicas.
When this setting is un-checked, Longhorn Manager will forbid scheduling new replicas of a volume to the same disks as existing healthy replicas.

> **Note:**
> - Even if the setting is "true" and disk sharing is allowed, Longhorn will seek to use a different disk if possible, even if on the same node.
> - This setting is superseded if replicas are forbidden to share a zone or a node by either of the other Soft Anti-Affinity settings.
#### Replica Auto Balance

Expand Down
4 changes: 2 additions & 2 deletions content/docs/1.6.0/references/storage-class-parameters.md
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,9 @@ A list of recurring jobs that are to be run on a volume.
> More details in [Scheduling](../../volumes-and-nodes/scheduling).
#### Backend Store Driver *(field: `parameters.backendStoreDriver`)*
> Default: `""`
> Default: `"v1"`
- Use "spdk" to run the v2 SPDK-based engine.
- Use "v2" to run the v2 SPDK-based engine (experimental in 1.6.) If empty, "v1" is assumed.

> Global setting: [V2 Data Engine](../settings#v2-data-engine).
> More details in [V2 Data Engine Quick Start](../../spdk/quick-start#create-a-storageclass).
Expand Down

0 comments on commit 0b22c15

Please sign in to comment.