Fix jsk-recognition-msgs on noetic #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package looks at the ROS_VERSION variable and fails to find it without this.
Gets around:
> error: Multiple top-level packages discovered in a flat-layout: ['srv', 'msg', 'sample', 'action'].
>
> To avoid accidental inclusion of unwanted files or directories,
> setuptools will not proceed with this build.
>
> If you are trying to create a single distribution with multiple packages
> on purpose, you should not rely on automatic discovery.
> Instead, consider the following options:
>
> 1. set up custom discovery (`find` directive with `include` or `exclude`)
> 2. use a `src-layout`
> 3. explicitly set `py_modules` or `packages` with a list of names
>
> To find more information, look for "package discovery" on setuptools docs.
> CMake Error at catkin_generated/safe_execute_install.cmake:4 (message):
>
> execute_process(/build/jsk_recognition-release-release-noetic-jsk_recognition_msgs-1.2.17-2/build/catkin_generated/python_distutils_install.sh)
> returned error code
> Call Stack (most recent call first):
> cmake_install.cmake:46 (include)
>
>
> make: *** [Makefile:100: install] Error 1
|
@lopsided98 should we be specifying |
|
Hi, I'm not that much familiar with ROS 1 and not sure why are you asking, but the answer is likely yes. There are packages that use these variables at build time to decide how to build their code, e.g. which quirks need to be applied for compatibility with different ROS versions/distributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains two fixes:
The first is that
ROS_DISTROis read from the environment inCMakeLists.txt. The variable is only available whenros-environmentis included as a build input. I'm not sure how this worked before. (Add ros_environment jsk-ros-pkg/jsk_recognition#2836)The second build fix is removing
catkin_python_setupfromCMakeLists.txt(Changes to build in Ubuntu 22.04/24.04 jsk-ros-pkg/jsk_recognition#2829)Fixes #406