Add more tests

ls1intum · Nov 10, 2024 · 2ed5974 · 2ed5974
1 parent 1d248cf
commit 2ed5974
Showing 1 changed file with 170 additions and 0 deletions.
diff --git a/...cit/aet/artemis/programming/service/localci/scaparser/strategy/sarif/SarifParserTest.java b/...cit/aet/artemis/programming/service/localci/scaparser/strategy/sarif/SarifParserTest.java
@@ -303,4 +303,174 @@ void testInvalidJSON() {
         SarifParser parser = new SarifParser(StaticCodeAnalysisTool.OTHER, new IdCategorizer());
         assertThatThrownBy(() -> parser.parse(report)).hasCauseInstanceOf(JsonProcessingException.class);
     }
+
+    @Test
+    void testFilterMalformedSarif() {
+        String report = """
+                {
+                    "runs": [
+                        {
+                            "tool": {
+                                "driver": {}
+                            },
+                            "results": [
+                                {
+                                    "locations": [
+                                        {
+                                            "physicalLocation": {
+                                                "artifactLocation": {
+                                                    "uri": "file:///path/to/file.txt"
+                                                },
+                                                "region": {
+                                                    "startLine": 1
+                                                }
+                                            }
+                                        }
+                                    ],
+                                    "message": {
+                                        "text": "VALID"
+                                    },
+                                    "ruleId": "A001"
+                                },
+                                {
+                                    "locations": [
+                                        {
+                                            "physicalLocation": {
+                                                "artifactLocation": {
+                                                    "uri": "file:///path/to/file.txt"
+                                                }
+                                            }
+                                        }
+                                    ],
+                                    "message": {
+                                        "text": "REGION MISSING"
+                                    },
+                                    "ruleId": "A002"
+                                },
+                                {
+                                    "locations": [
+                                        {
+                                            "physicalLocation": {
+                                                "artifactLocation": {
+                                                    "uri": "file:///path/to/file.txt"
+                                                },
+                                                "region": {
+                                                    "startLine": 1
+                                                }
+                                            }
+                                        }
+                                    ],
+                                    "message": {
+                                        "text": "NO_RULE_ID"
+                                    }
+                                },
+                                {
+                                    "locations": [
+                                        {
+                                            "physicalLocation": {
+                                                "artifactLocation": {
+                                                    "uri": "file:///path/to/file.txt"
+                                                },
+                                                "region": {
+                                                    "startLine": 1
+                                                }
+                                            }
+                                        }
+                                    ],
+                                    "message": {
+                                        "id": "INVALID_MESSAGE_ID"
+                                    },
+                                    "ruleId": "A004"
+                                }
+                            ]
+                        }
+                    ]
+                }
+                """;
+
+        SarifParser parser = new SarifParser(StaticCodeAnalysisTool.OTHER, new IdCategorizer());
+        StaticCodeAnalysisReportDTO parsedReport = parser.parse(report);
+
+        assertThat(parsedReport.issues()).singleElement().matches(issue -> issue.rule().equals("A001"));
+    }
+
+    @Test
+    void testFilterInformationMissing() {
+        String report = """
+                {
+                    "runs": [
+                        {
+                            "tool": {
+                                "driver": {}
+                            },
+                            "results": [
+                                {
+                                    "locations": [
+                                        {
+                                            "physicalLocation": {
+                                                "artifactLocation": {
+                                                    "uri": "file:///path/to/file.txt"
+                                                },
+                                                "region": {
+                                                    "startLine": 1
+                                                }
+                                            }
+                                        }
+                                    ],
+                                    "message": {
+                                        "text": "VALID"
+                                    },
+                                    "ruleId": "A001"
+                                },
+                                {
+                                    "message": {
+                                        "text": "LOCATION MISSING"
+                                    },
+                                    "ruleId": "A002"
+                                },
+                                {
+                                    "locations": [
+                                        {
+                                            "physicalLocation": {
+                                                "region": {
+                                                    "startLine": 1
+                                                }
+                                            }
+                                        }
+                                    ],
+                                    "message": {
+                                        "text": "PATH MISSING"
+                                    },
+                                    "ruleId": "A003"
+                                },
+                                {
+                                    "locations": [
+                                        {
+                                            "physicalLocation": {
+                                                "artifactLocation": {
+                                                    "uri": "file:///path/to/file.txt"
+                                                },
+                                                "region": {
+                                                    "byteOffset": 0,
+                                                    "byteLength": 10
+                                                }
+                                            }
+                                        }
+                                    ],
+                                    "message": {
+                                        "text": "NOT A TEXT REGION"
+                                    },
+                                    "ruleId": "A004"
+                                }
+                            ]
+                        }
+                    ]
+                }
+                """;
+
+        SarifParser parser = new SarifParser(StaticCodeAnalysisTool.OTHER, new IdCategorizer());
+        StaticCodeAnalysisReportDTO parsedReport = parser.parse(report);
+
+        assertThat(parsedReport.issues()).singleElement().matches(issue -> issue.rule().equals("A001"));
+    }
 }