Merge branch 'develop' into bugfix/general/add-sidebar-card-medium-ho…

…ver-effect

README.md

@@ -193,7 +193,7 @@ Refer to [Using JHipster in production](http://www.jhipster.tech/production) for
 The following command can automate the deployment to a server. The example shows the deployment to the main Artemis test server (which runs a virtual machine):
 
 ```shell
-./artemis-server-cli deploy [email protected] -w build/libs/Artemis-7.6.5.war
+./artemis-server-cli deploy [email protected] -w build/libs/Artemis-7.7.0.war
 ```
 
 ## Architecture

build.gradle

@@ -25,7 +25,7 @@ plugins {
 }
 
 group = "de.tum.cit.aet.artemis"
-version = "7.6.5"
+version = "7.7.0"
 description = "Interactive Learning with Individual Feedback"
 
 java {

package.json

@@ -1,6 +1,6 @@
 {
     "name": "artemis",
-    "version": "7.6.5",
+    "version": "7.7.0",
     "description": "Interactive Learning with Individual Feedback",
     "private": true,
     "license": "MIT",

src/main/webapp/app/exercises/shared/rating/rating.component.ts

@@ -15,6 +15,7 @@ export class RatingComponent implements OnInit, OnChanges {
     public rating: number;
     public disableRating = false;
     @Input() result?: Result;
+    private previousResultId?: number;
 
     constructor(
         private ratingService: RatingService,
@@ -26,7 +27,8 @@ export class RatingComponent implements OnInit, OnChanges {
     }
 
     ngOnChanges(changes: SimpleChanges): void {
-        if (changes['result'] && !changes['result'].isFirstChange()) {
+        if (changes['result'] && changes['result'].currentValue?.id !== this.previousResultId) {
+            this.previousResultId = changes['result'].currentValue?.id;
             this.loadRating();
         }
     }

src/test/javascript/spec/component/rating/rating.component.spec.ts

@@ -98,6 +98,20 @@ describe('RatingComponent', () => {
         expect(ratingComponent.rating).toBe(2);
     });
 
+    it('should not call loadRating if result ID remains the same', () => {
+        // without this condition the loadRating might be spammed making unnecessary api calls
+        const loadRatingSpy = jest.spyOn(ratingComponent, 'loadRating');
+        ratingComponent.result = { id: 90 } as Result;
+        ratingComponent.result.submission = { id: 1 } as Submission;
+        ratingComponent.result.participation = { id: 1 } as Participation;
+        jest.spyOn(ratingService, 'getRating').mockReturnValue(of(2));
+        ratingComponentFixture.detectChanges();
+        ratingComponent.result = { id: 90 } as Result;
+        ratingComponentFixture.detectChanges();
+        expect(loadRatingSpy).toHaveBeenCalledOnce();
+        expect(ratingComponent.rating).toBe(2);
+    });
+
     describe('OnRate', () => {
         beforeEach(() => {
             ratingComponent.rating = 0;