-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive learning
: Allow editors to edit the competency link weight
#9564
Adaptive learning
: Allow editors to edit the competency link weight
#9564
Conversation
…etency-link-weight
…-weight # Conflicts: # src/main/java/de/tum/cit/aet/artemis/atlas/service/competency/CompetencyService.java # src/main/java/de/tum/cit/aet/artemis/atlas/service/competency/CourseCompetencyService.java # src/main/java/de/tum/cit/aet/artemis/atlas/service/competency/PrerequisiteService.java # src/test/javascript/spec/component/competencies/competency-management/competency-management.component.spec.ts
Adaptive Learning
: Allow editors to edit the competency link weightAdaptive learning
: Allow editors to edit the competency link weight
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
…-weight # Conflicts: # src/main/java/de/tum/cit/aet/artemis/exercise/service/ExerciseDeletionService.java # src/main/java/de/tum/cit/aet/artemis/programming/repository/ProgrammingExerciseRepository.java # src/main/java/de/tum/cit/aet/artemis/text/repository/TextExerciseRepository.java
…feature/adaptive-learning/competency-link-weight-edit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintainer approved
…-weight # Conflicts: # src/main/webapp/app/exercises/programming/manage/update/update-components/programming-exercise-problem.component.html
…feature/adaptive-learning/competency-link-weight-edit
The base branch was changed.
…-weight-edit # Conflicts: # src/main/webapp/app/entities/competency.model.ts # src/main/webapp/app/shared/competency-selection/competency-selection.component.ts # src/test/javascript/spec/component/shared/competency-selection.component.spec.ts
Warning Rate limit exceeded@JohannesStoehr has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 7 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
The base branch was changed so all reviews were lost. This PR had enough approvals. |
🚨 Stacked on #9517 only merge after the other PR 🚨
Checklist
General
Client
Motivation and Context
#9446
continuation of #9517
Description
#9517 changed the database and object structure to support weights between competencies and learning objects.
This PR now adds a dropdown for all selected competencies to allow the user to choose between a 'low', 'medium' and 'high' weight of the link.
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Performance Tests
Test Coverage
Client
Screenshots
Weight dropdown only for selected competencies:
Tooltip explaining the weight: