General: Fix an issue where a translation is outdated
#9804
Conversation
github-actions
bot
added
the
client
edkaya
temporarily deployed
to
artemis-test3.artemis.cit.tum.de
GitHub Actions
Inactive
WalkthroughThe changes in this pull request involve an update to the HTML template of the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
src/main/webapp/app/exam/manage/student-exams/student-exam-timeline/programming-exam-diff/programming-exercise-exam-diff.component.html(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
🔇 Additional comments (1)
src/main/webapp/app/exam/manage/student-exams/student-exam-timeline/programming-exam-diff/programming-exercise-exam-diff.component.html (1)
5-7: LGTM! Proper usage of new Angular syntax.
The template correctly uses the new @if syntax instead of *ngIf throughout the file, adhering to the coding guidelines.
Also applies to: 18-40
...ms/student-exam-timeline/programming-exam-diff/programming-exercise-exam-diff.component.html
Show resolved
Hide resolved
| >[{{ exercise.maxPoints }} {{ 'artemisApp.examParticipation.points' | artemisTranslate }}] | ||
| >[{{ exercise.maxPoints }} {{ 'artemisApp.examParticipation.exercisePoints' | artemisTranslate }}] |
There was a problem hiding this comment.
We want to get away from using the artemisTranslate pipe, and instead use the jhiTranslate. You can also pass in values to the String with translateValues. If that's possible here, it would be nice
There was a problem hiding this comment.
Yes exactly, but using jhiTranslate here forces me to change the translation value of exercisePoints, because it uses brackets around the points, where I need to integrate those brackets into the translation value. But this translation key is also used in different parts of Artemis, and they don't use brackets, so I need to introduce a new translation only for this one. Therefore, keeping artemisTranslate here will be a better option in my opinion 😄
|
github-actions
bot
added
the
deployment-error
edkaya
removed
the
deployment-error
Checklist
General
Client
Motivation and Context
We updated some translations in exam mode in #9569, but one translation in exam timeline remained outdated.
Description
I updated the outdated translation.
Steps for Testing
Prerequisites:
(There is already an exam with a submitted programming exercise called "programming diff 2" on TS3 under my course.)
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Code Review
Manual Tests
Screenshots
Before
After
Summary by CodeRabbit
New Features
Bug Fixes