Communication: Fix disappearing messages and toolbar (#176)

* Fix message toolbar not showing up on iOS 18 * Use correct topic for websocket in non course-wide channels * Fix websocket connection for non course wide channels
ls1intum · Sep 20, 2024 · eca0a18 · eca0a18
1 parent 9b2e3e3
commit eca0a18
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 13 deletions.
diff --git a/ArtemisKit/Sources/Messages/ViewModels/ConversationViewModels/ConversationViewModel.swift b/ArtemisKit/Sources/Messages/ViewModels/ConversationViewModels/ConversationViewModel.swift
@@ -323,14 +323,24 @@ private extension ConversationViewModel {
 
     func subscribeToConversationTopic() {
         let topic: String
-        if conversation.baseConversation.type == .channel {
+        if conversation.baseConversation.type == .channel,
+           let channel = conversation.baseConversation as? Channel,
+           channel.isCourseWide == true {
             topic = WebSocketTopic.makeChannelNotifications(courseId: course.id)
         } else if let id = userSession.user?.id {
             topic = WebSocketTopic.makeConversationNotifications(userId: id)
         } else {
             return
         }
         if stompClient.didSubscribeTopic(topic) {
+            /// These web socket topics are the same across multiple channels.
+            /// We might need to wait until a previously open conversation has unsubscribed
+            /// before we can subscribe again
+            Timer.scheduledTimer(withTimeInterval: 5, repeats: false) { [weak self] _ in
+                DispatchQueue.main.async { [weak self] in
+                    self?.subscribeToConversationTopic()
+                }
+            }
             return
         }
         subscription = Task { [weak self] in

diff --git a/ArtemisKit/Sources/Messages/Views/SendMessageViews/SendMessageView.swift b/ArtemisKit/Sources/Messages/Views/SendMessageViews/SendMessageView.swift
@@ -33,7 +33,7 @@ struct SendMessageView: View {
             }
             textField
                 .padding(isFocused ? [.horizontal, .bottom] : .all, .l)
-            if viewModel.isEditing && isFocused {
+            if isFocused {
                 keyboardToolbarContent
                     .padding(.horizontal, .l)
                     .padding(.vertical, .m)
@@ -101,13 +101,6 @@ private extension SendMessageView {
             .textFieldStyle(.roundedBorder)
             .lineLimit(10)
             .focused($isFocused)
-            .toolbar {
-                if isFocused && !viewModel.isEditing {
-                    ToolbarItem(placement: .keyboard) {
-                        keyboardToolbarContent
-                    }
-                }
-            }
             if !isFocused {
                 sendButton
             }

diff --git a/ArtemisKit/Sources/Notifications/Services/NotificationWebsocketServiceImpl.swift b/ArtemisKit/Sources/Notifications/Services/NotificationWebsocketServiceImpl.swift
@@ -64,10 +64,11 @@ class NotificationWebsocketServiceImpl: NotificationWebsocketService {
             await subscribeToTutorialGroupNotificationUpdates()
         }
         addTask(subscribeToTutorialGroupNotificationUpdatesTask)
-        let subscribeToConversationNotificationUpdatesTask = Task {
-            await subscribeToConversationNotificationUpdates()
-        }
-        addTask(subscribeToConversationNotificationUpdatesTask)
+#warning("We can't subscribe to this here and in the conversation simultaneously")
+//        let subscribeToConversationNotificationUpdatesTask = Task {
+//            await subscribeToConversationNotificationUpdates()
+//        }
+//        addTask(subscribeToConversationNotificationUpdatesTask)
 
         return stream
     }