Apply suggestions from code review

Co-authored-by: FG-TUM <[email protected]>
ls1mardyn · Nov 28, 2024 · c0c7aae · c0c7aae
1 parent 2363140
commit c0c7aae
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 17 deletions.
diff --git a/src/parallel/boundaries/BoundaryHandler.cpp b/src/parallel/boundaries/BoundaryHandler.cpp
@@ -131,9 +131,7 @@ void BoundaryHandler::processGlobalWallLeavingParticles(ParticleContainer *molec
 				break;
 			}
 			default:
-				std::ostringstream error_message;
-				error_message << "BoundaryType::ERROR received in BoundaryHandler::processGlobalWallLeavingParticles!" << std::endl;
-				MARDYN_EXIT(error_message.str());
+				MARDYN_EXIT("BoundaryType::ERROR received in BoundaryHandler::processGlobalWallLeavingParticles!");
 		}
 	}
 }
@@ -169,9 +167,7 @@ void BoundaryHandler::removeNonPeriodicHalos(ParticleContainer *moleculeContaine
 				break;
 			}
 			default:
-				std::ostringstream error_message;
-				error_message << "BoundaryType::ERROR received in BoundaryHandler::removeNonPeriodicHalos!" << std::endl;
-				MARDYN_EXIT(error_message.str());
+				MARDYN_EXIT("BoundaryType::ERROR received in BoundaryHandler::removeNonPeriodicHalos!");
 		}
 	}
 }
diff --git a/src/parallel/boundaries/DimensionUtils.cpp b/src/parallel/boundaries/DimensionUtils.cpp
@@ -69,10 +69,7 @@ std::string DimensionUtils::convertDimensionToString(DimensionType dimension) {
 		case DimensionType::NEGZ:
 			return "-z";
 		default: // ERROR
-			std::ostringstream error_message;
-			error_message << "DimesionType::ERROR received in DimensionUtils::convertDimensionToString!"
-									 << std::endl;
-			MARDYN_EXIT(error_message.str());
+			MARDYN_EXIT("DimesionType::ERROR received in DimensionUtils::convertDimensionToString!");
 			return "error";
 	}
 }
@@ -96,10 +93,7 @@ int DimensionUtils::convertDimensionToNumeric(DimensionType dimension) {
 		case DimensionType::NEGZ:
 			return -3;
 		default:
-			std::ostringstream error_message;
-			error_message << "DimesionType::ERROR received in DimensionUtils::convertDimensionToNumeric!"
-									 << std::endl;
-			MARDYN_EXIT(error_message.str());
+			MARDYN_EXIT("DimesionType::ERROR received in DimensionUtils::convertDimensionToNumeric!");
 			return 0;
 	}
 }

diff --git a/src/parallel/boundaries/RegionUtils.cpp b/src/parallel/boundaries/RegionUtils.cpp
@@ -41,9 +41,7 @@ std::tuple<std::array<double, 3>, std::array<double, 3>> RegionUtils::getInnerRe
 			break;
 
 		default:
-			std::ostringstream error_message;
-			error_message << "DimensionType::ERROR received in RegionUtils::getInnerRegionSlab" << std::endl;
-			MARDYN_EXIT(error_message.str());
+			MARDYN_EXIT("DimensionType::ERROR received in RegionUtils::getInnerRegionSlab");
 	}
 	return {returnRegionBegin, returnRegionEnd};
 }