-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding includes to cstdint #257
Conversation
We should actually remove the |
@LouieVoit What's the situation with this PR? Is it already reviewable? |
I was about to remove the 'using namespace std' as suggested per @amartyads but then it was done in #260 . Maybe we could merge both PR ? |
Your PR as it is now doesn't touch the namespaces. Let's keep things clean and separated and merge this one to master asap. |
But the PR #260 doesn't add |
No this will break #260 and not master. Thus, the polite way would be to add |
I've added |
What is the status of this PR ? Can it be merged now ? |
Description
To fix #256, I've added include to the C++ cstdint in some files and changed include to stdint.h to cstdint.
In some files, there is a
using namespace std
hence thestd::uint*_t
is used but in some files it is not present. So I don't know which one is used but it compiles now. I wanted to solve the issue with as little modifications as possible in the code. But should we add the std namespace everywhere ?How Has This Been Tested?
ls1 compiles fine with gcc 13.1.1 and clang 15.0.7. I've tried to compile with older versions of gcc and clang and it works as well.