Code refactor mamico #273
Merged
Code refactor mamico #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s1-mardyn into code-refactor-mamico
When same code is tested with clang (at all optimization levels) and with gcc optimization O0, the code runs bugfree, but with gcc O3 a segfault occurs when the cell service is accessed. This is a workaround pending more investigation, however it is not known whether a better solution exists yet.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1218
to
+1223
| /* | ||
| ensemble.updateGlobalVariable(ENERGY); | ||
| global_log->debug() << "Kinetic energy in the Ensemble: " << ensemble.E() << endl; | ||
| ensemble.updateGlobalVariable(TEMPERATURE); | ||
| global_log->debug() << "Temperature of the Ensemble: " << ensemble.T() << endl; | ||
| */ |
Check notice
Code scanning / CodeQL
Commented-out code Note
FG-TUM
requested changes
Sep 6, 2023
Co-authored-by: FG-TUM <[email protected]>
Co-authored-by: FG-TUM <[email protected]>
FG-TUM
reviewed
Sep 7, 2023
FG-TUM
requested changes
Sep 7, 2023
FG-TUM
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the necessary functionality and documentation for coupling ls1 to mamico. The simulation loop has been separated to enable step-by-step progression of simulation, a plugin has been added and updated, and the build process has been altered to allow building ls1 as a library.
How Has This Been Tested?
Multiple runs with Mamico in a variety of hardware and scenarios on ls1 side