Fixes and improvements for the MMPLD writer #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Niethammer <[email protected]>
The MMPLD file format includes a seek table for the data frames. The last entry of this table should point at the end of the last frame. However, this is not identical to the file size in some cases. Correct seek table entries are already inserted by the write_frame() method. Therefore, removing the erroneous code in the finish() method. Signed-off-by: Christoph Niethammer <[email protected]> Co-authored-by: HomesGH <[email protected]>
The MMPLD file format (version 1.2) is little endian only. The MMPLD writer uses simple byte writes without conversions so we have to make sure that we are running on a little endian system. Signed-off-by: Christoph Niethammer <[email protected]>
cniethammer
added
bug
HomesGH
requested changes
Dec 8, 2023
|
I am not sure if this problem is related to the fixes in this PR as mmpldinfo.py reported for me also errors before on the surface-tension example. |
Ok, alright. At least those bugs are fixed then ;) |
HomesGH
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes and minor improvements for the MMPLD writer:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.