Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused compression code #357

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

cniethammer
Copy link
Contributor

This code implementing some compression wrapper was never used elsewhere in the codebase and has been unmaintained for around 6 years.

This is work performed in the context of the general code cleanup in #282

@cniethammer cniethammer added the clean-up related to the clean-up of the code and tech dept label Dec 8, 2024
@cniethammer cniethammer requested a review from FG-TUM December 8, 2024 16:29
Copy link
Member

@FG-TUM FG-TUM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with removing his unused part of the code but please address the merge conflicts first.

This code implementing some compression wrapper was never used elsewhere in
the codebase and has been unmaintained for around 6 years.

Signed-off-by: Christoph Niethammer <[email protected]>

# Conflicts:
#	src/plugins/tests/compressionTest.cpp
#	src/plugins/tests/compressionTest.h
@cniethammer cniethammer force-pushed the remove_compression_code branch from 75bdefc to 43f0ac1 Compare December 9, 2024 17:48
@cniethammer cniethammer requested a review from FG-TUM December 10, 2024 12:25
@cniethammer cniethammer merged commit be67309 into ls1mardyn:master Dec 11, 2024
52 checks passed
@cniethammer cniethammer deleted the remove_compression_code branch December 11, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean-up related to the clean-up of the code and tech dept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants