Logger update #359
Open
Logger update #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniethammer
added
bug
This was referenced Dec 11, 2024
FG-TUM
requested changes
Dec 11, 2024
HomesGH
requested changes
Dec 12, 2024
|
I would like to remove the MPI dependencies, but I think for the moment I will put my effort into other parts of the code/PRs first ... Consider this PR as ready after applying the suggested updates, now. :) |
FG-TUM
requested changes
Dec 12, 2024
|
CI seems to have some issues - seem to be some issues with AutoPas that also break tests for other PRs ...? |
Seems like the update to the GitHub Ubuntu images messed up something with the dependencies. I'll fix it later Working again in #360 |
Signed-off-by: Christoph Niethammer <[email protected]>
Implement set_log_stream to change the output stream of the logger after logger construction. Signed-off-by: Christoph Niethammer <[email protected]>
Construct the global logger just after MPI_init with the default output stream (stdout). After command line parsing, switch the output stream of the global logger to a logfile if requested via the '--logfile' command line option. Signed-off-by: Christoph Niethammer <[email protected]>
As now the logger output stream can be set after default construction, remove the constructor for logfiles as it is not used any more. This also helps removing the MPI code from the logger. Signed-off-by: Christoph Niethammer <[email protected]>
The Logger constructor now takes a shared pointer to a std::ostream. In this way we do not need the error prone handling of manual stream descruction any more. Instead the default shared pointer argument for std::cout takes now the no-op deleter. Signed-off-by: Christoph Niethammer <[email protected]>
Co-authored-by: FG-TUM <[email protected]>
Signed-off-by: Christoph Niethammer <[email protected]>
Signed-off-by: Christoph Niethammer <[email protected]>
Signed-off-by: Christoph Niethammer <[email protected]>
A logger can now be copied, as it does not manage the stream it logs to itself but keeps an shared pointer, now. Signed-off-by: Christoph Niethammer <[email protected]>
Signed-off-by: Christoph Niethammer <[email protected]>
Just comparing a single character is not a good idea: 'do not log anything please' would enable debug output ... Skipping uppercase conversion as we always emit an error if the provided level name cannot be identified. Signed-off-by: Christoph Niethammer <[email protected]>
cniethammer
force-pushed
the
logger-update
branch
from
01f655a to
3c6e79c
Compare
|
Rebased and force pushed after CI update to rerun tests |
|
@FG-TUM: CI now looks good - not sure which change requests are still open ... may have got lost due to the manual push updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the possibility to change the output stream of the logger. The logger is now default initialized with output to std::cout right after
MPI_init. The output is changed to a log file later if requested via command line arguments. This resolves the segfault brought up during the review of PR #355 and takes into account the comments on the initial fix in PR #358.As the explicit constructor for logfiles is not needed any more, now, got rid of this in preparation for removing dependencies to MPI.
Also, refactored the time output code to use std::chrono where possible
Update:
Allow copying of loggers.
Fixed setting the log level by string: now case-matches instead of just looking for the leading character.