Tchipev fixes mixing rules

[tchipev]

Fix #74 and #75 and many of #73 .

[pramathe]

I think this ugly lines distributed on many spots in the code should be removed completely. Mixing rules parameters should be read only via XML and be stored at only one reasonable location in the code.

[pramathe]

I think we should get rid of this check in Simulation.cpp completely. There should be a check at the location directly when reading in the mixing rule parameters, if they are corrupted like to less or to many values specified.

[pramathe]

I dont think that this is correct. Should be symmetric.

[SteffenSeckler]

@tchipev any update on this?

[tchipev]

Hi, I've modified the changes accordingly, but not pushed them yet. I need to test them and can then commit. Will try to get to it today or tomorrow.

[tchipev]

OK, should be good now.

[SteffenSeckler]

the tests are failing for this PR. Can you adapt them?

[tchipev]

Sorry, I don't have the code in my head anymore. Could you please take over?

I think I added more safety checks and changed the program to abort in case of dubious input (when only some mixing rules are specified). This, however, breaks backwards compatibility which were the failing checks, if I remember correctly. Since this breaks backwards compatibility, maybe you can briefly discuss it with application users.

Thanks!

[SteffenSeckler]

not mergable as tests have to be adapted

[tchipev]

Hey! I saw that! :)

…

On Thu, Jan 28, 2021 at 4:59 PM Steffen Seckler ***@***.***> wrote: Closed #76 <#76>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFRCNJWT4F3EU7V4F4GALF3S4GCWHANCNFSM4HFTQXLA> .