Oscilloscope mode redesign #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PROPHESSOR
commented
Dec 22, 2023
•
PROPHESSOR
commented
- Move "Mode" to the top of the graph and make radio buttons instead of combo box
|
Implemented for x1 |
|
I can not confirm this issue because it is in undone state.
|
sadko4u
requested changes
Dec 23, 2023
| @@ -5,8 +5,8 @@ | |||
| "dc": "DC" | |||
| }, | |||
| "mode": { | |||
| "goniometer": "Goniometer", | |||
| "triggered": "Triggered", | |||
| "goniometer": "Stereo image", | |||
There was a problem hiding this comment.
It is a bad idea to make text associated with the key to differ the initial key sense.
If you want to change the label, please consider adding new key "stereo_image".
| "goniometer": "Goniometer", | ||
| "triggered": "Triggered", | ||
| "goniometer": "Stereo image", | ||
| "triggered": "Wave form", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.