Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add T&S pre-commit settings to ts_imsim. #15

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

jbkalmbach
Copy link
Member

No description provided.

@jbkalmbach jbkalmbach force-pushed the tickets/DM-41450 branch 5 times, most recently from fc8d2fc to d3038be Compare November 2, 2023 23:16
@jbkalmbach jbkalmbach marked this pull request as ready for review November 2, 2023 23:16
@gmegh
Copy link
Contributor

gmegh commented Nov 3, 2023

Hi! Just jumping in here. Maybe we can wait to merge this until the other PR #14 is merged? I say so, because it seems this one applies flake8 and black to all the files, and it may be good to do it again with the updated code with snake_case.

@jbkalmbach jbkalmbach force-pushed the tickets/DM-41450 branch 2 times, most recently from b3e5030 to 5564ba1 Compare November 7, 2023 22:58
Copy link
Contributor

@suberlak suberlak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.pre-commit-config.yaml Show resolved Hide resolved
@jbkalmbach jbkalmbach force-pushed the tickets/DM-41450 branch 4 times, most recently from b4bf57d to 6150906 Compare November 13, 2023 23:47
Copy link

@teweitsai teweitsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me

@jbkalmbach jbkalmbach force-pushed the tickets/DM-41450 branch 3 times, most recently from 9c4244f to 5ba2c15 Compare November 14, 2023 20:31
@jbkalmbach jbkalmbach merged commit ede8c6a into develop Nov 14, 2023
4 checks passed
@jbkalmbach jbkalmbach deleted the tickets/DM-41450 branch November 14, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants