Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct zenith angle into imsim configuration files. #20

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

jbkalmbach
Copy link
Member

@jbkalmbach jbkalmbach commented Nov 15, 2023

The Zenith angle in the AOS perturbations was always set to 0.0. We want it to be consistent with the actual Zenith of the telescope as we move around the sky.

@jbkalmbach jbkalmbach marked this pull request as ready for review November 15, 2023 00:38
@jbkalmbach jbkalmbach changed the title Add correct zenith angle into imsim configuration files. Add parallac… Add correct zenith angle into imsim configuration files. Nov 15, 2023
Copy link
Contributor

@gmegh gmegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just two small changes and I think this is good to go

python/lsst/ts/imsim/obs_metadata.py Show resolved Hide resolved
tests/test_obs_metadata.py Show resolved Hide resolved
@jbkalmbach jbkalmbach merged commit 7aace85 into develop Nov 15, 2023
4 checks passed
@jbkalmbach jbkalmbach deleted the tickets/DM-41714 branch November 15, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants