Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/dm 41569 #23

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Tickets/dm 41569 #23

merged 2 commits into from
Dec 19, 2023

Conversation

jbkalmbach
Copy link
Member

No description provided.

@jbkalmbach jbkalmbach force-pushed the tickets/DM-41569 branch 3 times, most recently from c5a3f3a to 18d4f53 Compare December 15, 2023 20:35
Replace inst_name with cam_type in ts_imsim.
Update tests.
@jbkalmbach jbkalmbach marked this pull request as ready for review December 15, 2023 20:59
Copy link
Contributor

@gmegh gmegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a couple of comments. Maybe the extra function I suggest would clear up the code a bit. Thanks for this!

python/lsst/ts/imsim/closed_loop_task.py Outdated Show resolved Hide resolved
python/lsst/ts/imsim/closed_loop_task.py Outdated Show resolved Hide resolved
Copy link
Contributor

@gmegh gmegh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jbkalmbach jbkalmbach merged commit 76696b4 into develop Dec 19, 2023
4 checks passed
@jbkalmbach jbkalmbach deleted the tickets/DM-41569 branch December 19, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants