Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tickets/DM-42848: fit up to zk28 #34

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Tickets/DM-42848: fit up to zk28 #34

merged 4 commits into from
Mar 6, 2024

Conversation

suberlak
Copy link
Contributor

@suberlak suberlak commented Mar 5, 2024

No description provided.

@suberlak suberlak force-pushed the tickets/DM-42848 branch 2 times, most recently from 7eb989f to 25ffdce Compare March 5, 2024 23:14
@suberlak suberlak requested a review from jbkalmbach March 5, 2024 23:17
jbkalmbach
jbkalmbach reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@jbkalmbach jbkalmbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain more about what the point of doing this is? It doesn't look like it changes anything based upon the test.

tests/testData/opd/opd.zer Show resolved Hide resolved
@suberlak
Copy link
Contributor Author

suberlak commented Mar 6, 2024

This change was needed to align how ts_imsim fits the OPD map to imSim . The difference is indeed very small - here we show the fit to test data opd.fits :
image
the difference is more noticeable only in the residuals plot more directly :
image
And that is reflected in the opd.zer file (the truth ) being changed

@suberlak suberlak requested a review from jbkalmbach March 6, 2024 22:38
jbkalmbach
jbkalmbach approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@jbkalmbach jbkalmbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification. Looks good.

python/lsst/ts/imsim/imsim_cmpt.py Show resolved Hide resolved
@suberlak suberlak merged commit f61f94f into develop Mar 6, 2024
4 checks passed
@suberlak suberlak deleted the tickets/DM-42848 branch March 6, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbkalmbach jbkalmbach jbkalmbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suberlak @jbkalmbach