tickets/DM-43313: Add danish to ts_imsim #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teweitsai
reviewed
Mar 14, 2024
jbkalmbach
force-pushed
the
tickets/DM-43313
branch
2 times, most recently
from
80eeb36
to
ae9b9d0
Compare
suberlak
approved these changes
Mar 15, 2024
| @@ -1037,8 +1062,12 @@ def run_img( | |||
| Raw seeing in arcsec. | |||
| imsim_log_file : str | |||
| Location to save imsim log output. | |||
| wep_estimator_method : str | |||
| Specify the method used to calculate Zernikes in ts_wep. | |||
| Options are "Tie" or "danish". | |||
There was a problem hiding this comment.
Is it intentional that "Tie" starts from uppercase, and "danish" does not? Would it hurt to use "tie" and "danish"?
There was a problem hiding this comment.
ok, reading below I think it's just a typo, as add_argument has tie and danish as I suspected
There was a problem hiding this comment.
Yeah, typo. Thanks for the catch. Fixed now.
Add wep_estimator option to img_closed_loop to enable switching between tie and danish in WEP.
jbkalmbach
force-pushed
the
tickets/DM-43313
branch
from
ae9b9d0
to
aab4e2f
Compare
|
For convergence plots see the document here: https://confluence.lsstcorp.org/display/LTS/WEP+Estimation+Algorithms |
|
Danish successfully converges for LSST FAM, ComCam and CWFS modes. Here is CWFS as an example (more plots in document in last comment): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wep_estimator option to img_closed_loop to enable switching between tie and danish in WEP.