Update to use ts_ofc v3.2.0 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbkalmbach
approved these changes
Jul 17, 2024
doc/versionHistory.rst
Outdated
| @@ -5,6 +5,12 @@ | |||
| ################## | |||
| Version History | |||
| ################## | |||
| ------------- | |||
| 1.5.7 | |||
There was a problem hiding this comment.
I think since you updated the command line structure with new functionality this should be bumped to 1.6.0.
jbkalmbach
reviewed
Jul 17, 2024
| @@ -1428,6 +1437,13 @@ def set_img_parser(parser: ArgumentParser) -> ArgumentParser: | |||
| """, | |||
| ) | |||
|
|
|||
| parser.add_argument( | |||
There was a problem hiding this comment.
test_set_img_parser in test_closed_loop_task should be updated to test this new config.
There was a problem hiding this comment.
Actually I think this belongs more with the default_parser above and not in the img_parser which contains settings specific to the images in the simulation. So this should be moved above and then a line in the test for this should be added to test_default_parser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged once lsst-ts/ts_ofc#62 is merged