Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47325: (hotfix) URL quote the config directory for URI test #1128

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

timj
Copy link
Member

@timj timj commented Dec 6, 2024

This can be necessary if there are special characters in the parent path.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes
  • (if changing dimensions.yaml) make a copy of dimensions.yaml in configs/old_dimensions

This can be necessary if there are special characters in the
parent path.
@timj timj requested a review from ktlim December 6, 2024 16:10
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.46%. Comparing base (d66c8bb) to head (60cf16e).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1128   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files         366      366           
  Lines       48773    48774    +1     
  Branches     5907     5907           
=======================================
+ Hits        43636    43637    +1     
  Misses       3721     3721           
  Partials     1416     1416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktlim ktlim merged commit 0155486 into main Dec 6, 2024
19 checks passed
@ktlim ktlim deleted the tickets/DM-47325-hotfix branch December 6, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants